magento2-37712: Exception handling inconsistency between developer and production modes
Community fix magento2-37712 merged into magento/magento2 on 2024-05-28, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
- Pull request title
- Fix exception handling inconsistency between developer and production modes
- Pull request
- magento/magento2#37712
- Issues
- #38639 pr-derived
- Author
- @iGerchak
- Merged
- 2024-05-28
- Fixed in
- 2.4.8
- Reported on
- 2.4.5
- Categories
- —
- Components
- magento/framework
Labels
- Area
- Framework
- Component
- Framework/Exception
- Priority
- P2
- Severity
- —
- Reported on (labels)
- 2.4.x
Issue
Title and steps come from the upstream issue and pull request.
Description
\Magento\Customer\Controller\AccountInterface class into the custom controller we got redirected to the login page (as was expected), but on the production on the same flow we got an internal server error 500.It happened because the redirect URL was set to the response before the trigger exception and as a result
Location header was sent to the browser and the browser redirect to the login page instead of the page with an exception message.It's not expected flow between developer and production modes and can cause some issues for production.
Taken from the upstream pull request.
Error signatures
- use LogicException;
- use Magento\Framework\Exception\SessionException;
- * @throws LogicException
- * @throws SessionException
- throw new LogicException(__('Some exception text'));
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 97.5%. Probability it is security relevant: 11.9%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 96.0%, refactor 1.5%, tests_only 0.8%, feature 0.8%, dependency 0.5%, docs_only 0.5% | 90.6% |
| Area | framework | framework 92.0%, customer 3.4%, frontend 1.1% | 82.6% |
| Reported version | 2.4.5 | 2.4.5 45.3%, 2.4.5-p1 5.0%, unspecified 2.1% | 20.2% |
| Scope | 0.28 of 2 | 0 77.2%, 1 17.8%, 2 5.0% | 44.5% |
| Risk | 0.60 of 2 | 0 50.4%, 1 39.1%, 2 10.5% | 12.7% |
| Worth backporting | 1.55 of 2 | 2 64.5%, 1 25.9%, 0 9.6% | 23.9% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-37712/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-37712 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/37712 Issue: https://github.com/magento/magento2/issues/38639 Author: @iGerchak Source commit: 03d4568bc7eaa56176cde2155375e8cfdd11e8a2 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
