UPSTREAM FIX

magento2-38270: Duplicate cache fpc for same page with same query

Community fix magento2-38270 merged into magento/magento2 on 2025-04-25, released in 2.4.9; applies cleanly to 6 releases from 2.4.8 to 2.4.8-p5.

Pull request title: Duplicate cache fpc for same page with same query
Pull request: magento/magento2#38270
Issues: #38269 human
Author: @rogerdz
Merged: 2025-04-25
Fixed in: 2.4.9
Reported on: —
Categories: Cache, Catalog/Product
Components: magento/framework, magento/module-page-cache

Labels

Area: Catalog
Component: Cache, Framework/Cache
Priority: P2
Severity: —
Reported on (labels): 2.4.x

Issue

Title and steps come from the upstream issue and pull request.

Description

https://magento2.test/gear/bags.html?style_bags=24&activity=8 and https://magento2.test/gear/bags.html?activity=8&style_bags=24 and https://magento2.test/gear/bags.html?activity=8&style_bags=24& use difference fpc identifier => increase page cache folder size

Steps to reproduce

1. Clear cache: bin/magento cache:clean
2. Run command: curl -I --location-trusted 'https://magento2.test/gear/bags.html?activity=8&style_bags=24' | grep -i X-Magento-Cache-Debug, it will return x-magento-cache-debug: MISS => correct
3. Run command: curl -I --location-trusted 'https://magento2.test/gear/bags.html?activity=8&style_bags=24' | grep -i X-Magento-Cache-Debug, it will return x-magento-cache-debug: HIT => correct
4. Run command: curl -I --location-trusted 'https://magento2.test/gear/bags.html?style_bags=24&activity=8' | grep -i X-Magento-Cache-Debug => it return x-magento-cache-debug: MISS => wrong
5. Run command: curl -I --location-trusted 'https://magento2.test/gear/bags.html?activity=8&style_bags=24&' | grep -i X-Magento-Cache-Debug => it return x-magento-cache-debug: MISS => wrong

Expected result

Actual result

Taken from the upstream issue.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

Line	Code match per tag	Tests
2.4.6	2.4.6 file-missing 2.4.6-p1 file-missing 2.4.6-p2 file-missing 2.4.6-p3 file-missing 2.4.6-p4 file-missing 2.4.6-p5 file-missing 2.4.6-p6 file-missing 2.4.6-p7 file-missing 2.4.6-p8 file-missing 2.4.6-p9 file-missing 2.4.6-p10 file-missing 2.4.6-p11 file-missing 2.4.6-p12 file-missing 2.4.6-p13 file-missing 2.4.6-p14 file-missing 2.4.6-p15 file-missing	2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7	2.4.7 conflict 2.4.7-p1 conflict 2.4.7-p2 conflict 2.4.7-p3 conflict 2.4.7-p4 conflict 2.4.7-p5 conflict 2.4.7-p6 conflict 2.4.7-p7 conflict 2.4.7-p8 conflict 2.4.7-p9 conflict 2.4.7-p10 conflict	2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data
2.4.8	2.4.8 clean 2.4.8-p1 clean 2.4.8-p2 clean 2.4.8-p3 clean 2.4.8-p4 clean 2.4.8-p5 clean	2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: fails before, passes afterunit: fails before, passes after
2.4.9	2.4.9 conflictcontains the fix	2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 97.5%. Probability it is security relevant: 0.6%.

Show the model's answers and probabilities

Question	Answer	Probabilities	Confidence
Change kind	bugfix	bugfix 96.0%, refactor 1.9%, tests_only 0.8%, feature 0.6%, dependency 0.4%, docs_only 0.3%	90.6%
Area	framework	framework 95.8%, catalog 1.7%, frontend 0.8%	90.7%
Reported version	unspecified	unspecified 43.0%, 2.4.4 1.3%, 2.4.7-p4 1.1%	17.9%
Scope	0.76 of 2	0 41.5%, 1 40.7%, 2 17.7%	5.5%
Risk	0.59 of 2	1 49.8%, 0 45.4%, 2 4.9%	18.4%
Worth backporting	1.43 of 2	2 57.6%, 1 27.4%, 0 15.0%	14.4%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38270/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Bundle README (what the ZIP ships)

# magento2-38270

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/38270
Issue: https://github.com/magento/magento2/issues/38269
Author: @rogerdz
Source commit: 1bfa69bf176bb0d2afe5af65445f86544eaf1134
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.