magento2-38364: Calendar warning when the ICU locale data has no AmPmMarkers
Community fix magento2-38364 merged into magento/magento2 on 2024-05-16, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
Fixes the calendar warning when the ICU locale data has no AmPmMarkers edited
- Pull request title
- Exception: Warning: Trying to access array offset in... -> Calendar.php since upgrade to ICU 74.1 (PHP Intl)
- Pull request
- magento/magento2#38364
- Issues
- #38214 human
- Author
- @hostep
- Merged
- 2024-05-16
- Fixed in
- 2.4.8
- Reported on
- 2.4.6-p3
- Categories
- —
- Components
- magento/framework
Labels
- Area
- Framework
- Component
- —
- Priority
- P1
- Severity
- —
- Reported on (labels)
- 2.4.6-p3
Issue
Title and steps come from the upstream issue and pull request.
Description
Steps to reproduce
Expected result
Actual result
main.CRITICAL: Exception: Warning: Trying to access array offset on value of type null in /vendor/magento/framework/View/Element/Html/Calendar.php on line 114 in /vendor/magento/framework/App/ErrorHandler.php:62
Taken from the upstream issue.
Error signatures
- Errors on each store visit in exception.log:
- main.CRITICAL: Exception: Warning: Trying to access array offset on value of type null in
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: test could not run before the patch, passes afterunit: could not run before, passes after |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 97.2%. Probability it is security relevant: 0.9%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 94.3%, refactor 1.9%, tests_only 1.3%, dependency 1.1%, feature 0.9%, docs_only 0.5% | 86.9% |
| Area | framework | framework 74.6%, frontend 20.0%, admin 1.8% | 53.9% |
| Reported version | 2.4.6-p3 | 2.4.6-p3 60.9%, 2.4.6 3.0%, 2.4.6-p4 1.7% | 36.6% |
| Scope | 0.98 of 2 | 1 61.3%, 0 20.3%, 2 18.4% | 17.6% |
| Risk | 0.39 of 2 | 0 63.5%, 1 34.1%, 2 2.4% | 28.0% |
| Worth backporting | 1.67 of 2 | 2 73.7%, 1 19.6%, 0 6.8% | 37.8% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38364/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-38364 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38364 Issue: https://github.com/magento/magento2/issues/38214 Author: @hostep Source commit: 76459721a92e428df7182f83bdddacc87917e471 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
