magento2-38617: Wrong WAI-ARIA role nesting in the top menu
Community fix magento2-38617 merged into magento/magento2 on 2025-08-04, released in 2.4.9; applies cleanly to 33 releases from 2.4.6 to 2.4.8-p5.
Fixes wrong WAI-ARIA role nesting in the top menu edited
- Pull request title
- Accessibility: WAI-ARIA roles nesting wrong in menu
- Pull request
- magento/magento2#38617
- Issues
- #40045 pr-derived
- Author
- @mirianfalconi
- Merged
- 2025-08-04
- Fixed in
- 2.4.9
- Reported on
- —
- Categories
- —
- Components
- magento/module-theme
Labels
- Area
- Other Developer Tools
- Component
- Console
- Priority
- P2
- Severity
- —
- Reported on (labels)
- —
Issue
Title and steps come from the upstream issue and pull request.
Steps to reproduce
2. Open the Lighthouse and do the Accessibily analysis with this PR
### Resolved issues:
1. [x] resolves magento/magento2#40045: Accessibility: WAI-ARIA roles nesting wrong in menu
Taken from the upstream pull request.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before, passes afterunit: fails before, passes after |
| 2.4.8 | 2.4.8 clean 2.4.8-p1 clean 2.4.8-p2 clean 2.4.8-p3 clean 2.4.8-p4 clean 2.4.8-p5 clean | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: fails before, passes afterunit: fails before, passes after |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 93.4%. Probability it is security relevant: 1.1%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 94.5%, refactor 2.5%, feature 1.0%, tests_only 1.0%, dependency 0.5%, docs_only 0.5% | 87.1% |
| Area | frontend | frontend 90.5%, other 3.3%, framework 1.9% | 79.5% |
| Reported version | unspecified | unspecified 12.7%, 2.4.6 4.9%, 2.4.6-p1 3.2% | 1.9% |
| Scope | 0.90 of 2 | 1 54.5%, 0 28.0%, 2 17.5% | 10.9% |
| Risk | 0.55 of 2 | 1 49.6%, 0 47.7%, 2 2.7% | 21.1% |
| Worth backporting | 1.36 of 2 | 2 54.3%, 1 27.6%, 0 18.2% | 10.5% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38617/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-38617 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38617 Issue: https://github.com/magento/magento2/issues/40045 Author: @mirianfalconi Source commit: 2bdf70ad2231aaf6aa1ba408728538a138b759f6 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
