magento2-38794: An infinite loop when a di.xml virtual type refers to itself
Community fix magento2-38794 merged into magento/magento2 on 2024-12-21, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
Fixes an infinite loop when a di.xml virtual type refers to itself edited
- Pull request title
- avoid a misconfiguration infinite loop
- Pull request
- magento/magento2#38794
- Issues
- #38822 pr-derived
- Author
- @ergohack
- Merged
- 2024-12-21
- Fixed in
- 2.4.8
- Reported on
- —
- Categories
- —
- Components
- magento/framework
Labels
- Area
- Framework
- Component
- Backend
- Priority
- P2
- Severity
- —
- Reported on (labels)
- 2.4.x
Issue
Title and steps come from the upstream issue and pull request.
Description
di.xml files, are not supposed to be self‑referential, … but if they ever are this function will spin in an infinite loop.Steps to reproduce
di.xml <virtualType …> node to be self‑referential (i.e. not actually virtual). This will cause the app to spin, infinitely, on the dereferencing attempt. Note that the self‑reference can be from a chain of <virtualType …> nodes and not just a single node.Taken from the upstream pull request.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 94.1%. Probability it is security relevant: 1.1%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 91.5%, tests_only 2.9%, refactor 2.1%, feature 1.8%, dependency 0.8%, docs_only 0.8% | 80.8% |
| Area | framework | framework 97.0%, admin 0.9%, other 0.4% | 93.3% |
| Reported version | unspecified | unspecified 19.9%, 2.4.6 2.7%, 2.4.8 2.3% | 3.8% |
| Scope | 0.53 of 2 | 0 55.4%, 1 36.5%, 2 8.1% | 17.0% |
| Risk | 0.25 of 2 | 0 78.3%, 1 18.3%, 2 3.5% | 47.0% |
| Worth backporting | 1.20 of 2 | 2 42.7%, 1 34.8%, 0 22.5% | 3.1% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38794/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-38794 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38794 Issue: https://github.com/magento/magento2/issues/38822 Author: @ergohack Source commit: aff5fc0152e65dd1c0762ec98105e01684c9003b Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
