magento2-40780: Varnish misses the cache for URLs with the gad_campaignid tracking parameter
Community fix magento2-40780 merged into magento/magento2 on 2026-06-16, not in a release yet; applies cleanly to 2.4.9.
Varnish misses the cache for URLs with the gad_campaignid tracking parameter edited
- Pull request title
- Replace all gad_* parameters in VCL
- Pull request
- magento/magento2#40780
- Issues
- #40781 pr-derived
- Author
- @sprankhub
- Merged
- 2026-06-16
- Fixed in
- no release yet
- Reported on
- —
- Categories
- —
- Components
- magento/framework, magento/module-page-cache
Labels
- Area
- —
- Component
- —
- Priority
- —
- Severity
- —
- Reported on (labels)
- 2.4.x
Issue
Title and steps come from the upstream issue and pull request.
Description
gad_source, but also gad_campaignid and all future gad_* tracking parameters are replaced. This way, the page will still be served by Varnish when a tracking parameter like gad_campaignid is used in the URL.Steps to reproduce
2. Flush the cache.
3. Open the homepage like https://www.shop.tld/. It should load "slow" as you just flushed the cache.
4. Open the homepage like https://www.shop.tld/ again. It should load fast as it is now served through Varnish.
5. Open the homepage with the
gad_campaignid like https://www.shop.tld?gad_campaignid=abc.6. Without the changes to the VCL in this pull request, the homepage will load "slow" as it is not a cache hit. With this change, the homepage will load fast as it is a cache hit.
Taken from the upstream pull request.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 file-missing 2.4.6-p1 file-missing 2.4.6-p2 file-missing 2.4.6-p3 file-missing 2.4.6-p4 file-missing 2.4.6-p5 file-missing 2.4.6-p6 file-missing 2.4.6-p7 file-missing 2.4.6-p8 file-missing 2.4.6-p9 file-missing 2.4.6-p10 file-missing 2.4.6-p11 file-missing 2.4.6-p12 file-missing 2.4.6-p13 file-missing 2.4.6-p14 file-missing 2.4.6-p15 file-missing | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 file-missing 2.4.7-p1 file-missing 2.4.7-p2 file-missing 2.4.7-p3 file-missing 2.4.7-p4 file-missing 2.4.7-p5 file-missing 2.4.7-p6 file-missing 2.4.7-p7 file-missing 2.4.7-p8 file-missing 2.4.7-p9 file-missing 2.4.7-p10 file-missing | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflict 2.4.8-p1 conflict 2.4.8-p2 conflict 2.4.8-p3 conflict 2.4.8-p4 conflict 2.4.8-p5 conflict | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 clean | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 60.2%. Probability it is security relevant: 0.7%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 77.2%, feature 9.2%, cleanup 5.9%, refactor 5.6%, dependency 0.9%, docs_only 0.6%, tests_only 0.6% | 54.6% |
| Area | framework | framework 90.3%, other 4.3%, frontend 2.3% | 79.2% |
| Reported version | unspecified | unspecified 23.9%, 2.4.6 3.9%, 2.4.8 2.3% | 5.5% |
| Scope | 0.66 of 2 | 0 45.6%, 1 42.8%, 2 11.7% | 10.6% |
| Risk | 0.41 of 2 | 0 62.6%, 1 33.4%, 2 4.0% | 25.7% |
| Worth backporting | 1.45 of 2 | 2 57.6%, 1 29.8%, 0 12.6% | 15.5% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-40780/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-40780 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/40780 Issue: https://github.com/magento/magento2/issues/40781 Author: @sprankhub Source commit: 99432ff6ce2787b4fd69a1d200ea9779f6ca7973 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
