QUALITY PATCH

ACSD-63469: When multiple Fixed amount discount for whole cart rules are applied simultaneously…

When multiple Fixed amount discount for whole cart rules are applied simultaneously, and the products have discounted or special prices, the discount value is calculated incorrectly. Quality patch ACSD-63469 for magento/module-sales-rule applies to Magento Open Source and Adobe Commerce 2.4.7 to 2.4.7-p10.

Categories
Shopping Cart
Components
magento/module-sales-rule
Origin
adobe-commerce-support
Since QPT
1.1.59

Issue

When multiple Fixed amount discount for whole cart rules are applied simultaneously, and the products have discounted or special prices, the discount value is calculated incorrectly.

Steps to reproduce

1. Create two products priced at $850 and $85, and set their special prices to $765 and $68, respectively. 1. Create two Cart Price Rules as follows: * Rule 1 * Conditions: For the $850 product, set Qty to equals or greater than 2 * Actions: Apply Fixed amount discount for whole cart of $153 * Rule 2 * Conditions: For the $85 product, set Qty to equals or greater than 2 * Actions: Apply Fixed amount discount for whole cart of $14 1. Add both products to the cart, each with a quantity of 2.

Adobe's page lists 2.4.7 - 2.4.7-p4 as compatible; the versions below are resolved from the current QPT constraints and are the ones the tool will offer.

Adobe scheduled the permanent fix for 2.4.8.

Install

Install the Quality Patches Tool with composer require magento/quality-patches, apply the prerequisites listed for all files applicable to your distribution and version first, then run vendor/bin/magento-patches apply ACSD-63469. On Cloud, add ACSD-63469 under stage.build.QUALITY_PATCHES in .magento.env.yaml.

For cweagans/composer-patches, choose a compatible version below and download the bundle. Copy its ACSD-63469/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Bundle prerequisites the same way and list them first. Paths are relative to each package root, using the default -p1 level. Prefer local files when configuring composer-patches; a remote URL can change.

Patch files and compatible versions

Packages across compatible versions (1): magento/module-sales-rule
Packages across compatible versions (1): magento/module-sales-rule

magento/magento2-base >=2.4.7 <2.4.8

Magento Open Source
2.4.7-p10, 2.4.7-p9, 2.4.7-p8, 2.4.7-p7, 2.4.7-p6, 2.4.7-p5, 2.4.7-p4, 2.4.7-p3, 2.4.7-p2, 2.4.7-p1, 2.4.7
Adobe Commerce
2.4.7-p10, 2.4.7-p9, 2.4.7-p8, 2.4.7-p7, 2.4.7-p6, 2.4.7-p5, 2.4.7-p4, 2.4.7-p3, 2.4.7-p2, 2.4.7-p1, 2.4.7
Patch file
patches/os/ACSD-63469_2.4.7-p2_v2.patch
  • vendor/magento/module-sales-rule/Model/Rule/Action/Discount/ByFixed.php
  • vendor/magento/module-sales-rule/Model/Rule/Action/Discount/CartFixed.php
  • vendor/magento/module-sales-rule/Model/Rule/Action/Discount/ExistingDiscountRuleCollector.php (added)
  • vendor/magento/module-sales-rule/Model/Utility.php
  • vendor/magento/module-sales-rule/Model/Validator.php
  • vendor/magento/module-sales-rule/etc/di.xml

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.