ACSD-68925: Previously, invalid GraphQL requests generated internal server errors…
Previously, invalid GraphQL requests generated internal server errors, instead of the correct 4XX responses defined by the GraphQL over HTTP specification. Quality patch ACSD-68925 for magento/framework applies to Magento Open Source and Adobe Commerce 2.4.8 to 2.4.8-p4.
- Categories
- GraphQL
- Components
- magento/framework, magento/module-graph-ql, magento/theme-frontend-blank, magento/theme-frontend-luma
- Origin
- adobe-commerce-support
- Since QPT
- 1.1.75
Issue
Previously, invalid GraphQL requests generated internal server errors, instead of the correct 4XX responses defined by the GraphQL over HTTP specification.
Steps to reproduce
Send GraphQL request with an unknown/incorrect filter name. { cmsBlocks(identifiers: ["home"]) { items { title } } }
Adobe's page lists 2.4.8 - 2.4.8-p3 as compatible; the versions below are resolved from the current QPT constraints and are the ones the tool will offer.
Adobe scheduled the permanent fix for 2.4.9.
Install
Install the Quality Patches Tool with composer require magento/quality-patches, apply the prerequisites listed for all files applicable to your distribution and version first, then run vendor/bin/magento-patches apply ACSD-68925. On Cloud, add ACSD-68925 under stage.build.QUALITY_PATCHES in .magento.env.yaml.
For cweagans/composer-patches, choose a compatible version below and download the bundle. Copy its ACSD-68925/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Bundle prerequisites the same way and list them first. Paths are relative to each package root, using the default -p1 level. Prefer local files when configuring composer-patches; a remote URL can change.
Patch files and compatible versions
magento/magento2-base >=2.4.8 <2.4.8-p5
- Replaced with
- ACP2E-4815
- Patch file
- patches/os/ACSD-68925_2.4.8-p3.patch
- vendor/magento/module-graph-ql/Controller/GraphQl.php
- vendor/magento/module-graph-ql/Controller/HttpRequestValidator/ContentTypeValidator.php
- vendor/magento/module-graph-ql/Controller/HttpRequestValidator/HttpVerbValidator.php
- vendor/magento/theme-frontend-blank/i18n/en_US.csv
- vendor/magento/theme-frontend-luma/i18n/en_US.csv
- vendor/magento/framework/GraphQl/Exception/InvalidRequestInterface.php (added)
- vendor/magento/framework/GraphQl/Exception/MethodNotAllowedException.php (added)
- vendor/magento/framework/GraphQl/Exception/UnsupportedMediaTypeException.php (added)
- vendor/magento/framework/GraphQl/Schema/SchemaGenerator.php
- vendor/magento/framework/GraphQl/Schema/Type/TypeRegistry.php
