QUALITY PATCH

ACSD-51645: Getting an error when saving a new Cart Price Rule if the extension…

Getting an error when saving a new Cart Price Rule if the extension Magento_OfflineShipping is disabled. Quality patch ACSD-51645 for magento/module-sales-rule applies to Magento Open Source and Adobe Commerce 2.4.6 to 2.4.6-p15.

Categories
Price/Tax
Components
magento/module-sales-rule
Origin
adobe-commerce-support
Since QPT
1.1.33

Issue

Getting an error when saving a new Cart Price Rule if the extension Magento_OfflineShipping is disabled.

Steps to reproduce

1. Disable the Magento_OfflineShipping module. 1. Log in to Admin. 1. Go to Marketing > Cart Price Rules. 1. Create a new Cart Price Rule. 1. Fill the required fields. 1. Save the Cart Price Rule.

Adobe's page lists 2.4.6 - 2.4.6-p1 as compatible; the versions below are resolved from the current QPT constraints and are the ones the tool will offer.

Adobe scheduled the permanent fix for 2.4.7.

Install

Install the Quality Patches Tool with composer require magento/quality-patches, apply the prerequisites listed for all files applicable to your distribution and version first, then run vendor/bin/magento-patches apply ACSD-51645. On Cloud, add ACSD-51645 under stage.build.QUALITY_PATCHES in .magento.env.yaml.

For cweagans/composer-patches, choose a compatible version below and download the bundle. Copy its ACSD-51645/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Bundle prerequisites the same way and list them first. Paths are relative to each package root, using the default -p1 level. Prefer local files when configuring composer-patches; a remote URL can change.

Patch files and compatible versions

Packages across compatible versions (1): magento/module-sales-rule
Packages across compatible versions (1): magento/module-sales-rule

magento/magento2-base >=2.4.6 <2.4.7

Magento Open Source
2.4.6-p15, 2.4.6-p14, 2.4.6-p13, 2.4.6-p12, 2.4.6-p11, 2.4.6-p10, 2.4.6-p9, 2.4.6-p8, 2.4.6-p7, 2.4.6-p6, 2.4.6-p5, 2.4.6-p4, 2.4.6-p3, 2.4.6-p2, 2.4.6-p1, 2.4.6
Adobe Commerce
2.4.6-p15, 2.4.6-p14, 2.4.6-p13, 2.4.6-p12, 2.4.6-p11, 2.4.6-p10, 2.4.6-p9, 2.4.6-p8, 2.4.6-p7, 2.4.6-p6, 2.4.6-p5, 2.4.6-p4, 2.4.6-p3, 2.4.6-p2, 2.4.6-p1, 2.4.6
Patch file
patches/os/ACSD-51645_2.4.6.patch
  • vendor/magento/module-sales-rule/Controller/Adminhtml/Promo/Quote/Save.php

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.