QUALITY PATCH

ACSD-45241: Stock quantity for a virtual product is miscalculated after creating a credit memo

Stock quantity for a virtual product is miscalculated after creating a credit memo. Quality patch ACSD-45241 for magento/module-inventory-sales applies to Magento Open Source and Adobe Commerce 2.3.5 to 2.4.3-p3.

Categories
Inventory
Components
magento/module-inventory-sales
Origin
adobe-commerce-support
Since QPT
1.1.17

Issue

Stock quantity for a virtual product is miscalculated after creating a credit memo.

Steps to reproduce

1. Create a configurable product with a virtual product as a child product in the Commerce Admin. 1. Make sure both products created in step one are in stock. 1. Mark the quantity for the virtual product created in step one as 100 and keep the salable quantity 100 as well. 1. Add the product to the shopping cart. 1. Place an order with the virtual product created in step one. 1. Keep the order status as "Pending". No need to process the payment. 1. order_created record created in inventory_reservation. The virtual product quantity shows 100 with salable quantity as 99. 1. Open the order and go to Invoice > Submit Invoice. 1. invoice_created record created in inventory_reservation. The virtual product quantity is now 99, and the salable quantity is also 99. 1. Create a credit memo without selecting Return to Stock.

Adobe's page lists 2.3.5 - 2.4.4 as compatible; the versions below are resolved from the current QPT constraints and are the ones the tool will offer.

Install

Install the Quality Patches Tool with composer require magento/quality-patches, apply the prerequisites listed for all files applicable to your distribution and version first, then run vendor/bin/magento-patches apply ACSD-45241. On Cloud, add ACSD-45241 under stage.build.QUALITY_PATCHES in .magento.env.yaml.

For cweagans/composer-patches, choose a compatible version below and download the bundle. Copy its ACSD-45241/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Bundle prerequisites the same way and list them first. Paths are relative to each package root, using the default -p1 level. Prefer local files when configuring composer-patches; a remote URL can change.

Patch files and compatible versions

Packages across compatible versions (1): magento/module-inventory-sales
Packages across compatible versions (1): magento/module-inventory-sales

magento/inventory-composer-metapackage >=1.1.5 <1.2.0

Magento Open Source
2.3.7-p4, 2.3.7-p3, 2.3.7-p2, 2.3.7-p1, 2.3.7, 2.3.6-p1, 2.3.6, 2.3.5-p2, 2.3.5-p1, 2.3.5
Adobe Commerce
2.3.7-p4, 2.3.7-p3, 2.3.7-p2, 2.3.7-p1, 2.3.7, 2.3.6-p1, 2.3.6, 2.3.5-p2, 2.3.5-p1, 2.3.5
Requires
MDVA-36572
Patch file
patches/os/ACSD-45241_2.4.1.patch
  • vendor/magento/module-inventory-sales/Plugin/Sales/OrderManagement/DeductSourceItemQuantityOnRefundPlugin.php

magento/inventory-metapackage >=1.2.0 <1.2.4

Magento Open Source
2.4.3-p3, 2.4.3-p2, 2.4.3-p1, 2.4.3, 2.4.2-p2, 2.4.2-p1, 2.4.2, 2.4.1-p1, 2.4.1, 2.4.0-p1, 2.4.0
Adobe Commerce
2.4.3-p3, 2.4.3-p2, 2.4.3-p1, 2.4.3, 2.4.2-p2, 2.4.2-p1, 2.4.2, 2.4.1-p1, 2.4.1, 2.4.0-p1, 2.4.0
Requires
MDVA-36572
Replaced with
ACSD-46541
Patch file
patches/os/ACSD-45241_2.4.1.patch
  • vendor/magento/module-inventory-sales/Plugin/Sales/OrderManagement/DeductSourceItemQuantityOnRefundPlugin.php

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.