QUALITY PATCH

ACSD-58108: The missing join table name in the original fetching table causes SQL errors in the order…

The missing join table name in the original fetching table causes SQL errors in the order grid when using a custom module extension. Quality patch ACSD-58108 for magento/module-sales applies to Magento Open Source and Adobe Commerce 2.4.6 to 2.4.7-p10.

Categories
Order/Checkout, Admin
Components
magento/module-sales
Origin
adobe-commerce-support
Since QPT
1.1.69

Issue

The missing join table name in the original fetching table causes SQL errors in the order grid when using a custom module extension. This issue occurs because the addFilterToMap function does not work for certain columns after joining the sales_order_item table, resulting in errors while filtering.

Steps to reproduce

01. Install a 2.4-develop instance. 02. Create a new order. 03. Install a custom module with an SQL extension. 04. Navigate to Admin > Sales > Orders. 05. Apply the Purchase Date filter and wait for the result. 06. Apply Product SKU filter.

Adobe's page lists 2.4.6 - 2.4.7-p6 as compatible; the versions below are resolved from the current QPT constraints and are the ones the tool will offer.

Adobe scheduled the permanent fix for 2.5.0.

Install

Install the Quality Patches Tool with composer require magento/quality-patches, apply the prerequisites listed for all files applicable to your distribution and version first, then run vendor/bin/magento-patches apply ACSD-58108. On Cloud, add ACSD-58108 under stage.build.QUALITY_PATCHES in .magento.env.yaml.

For cweagans/composer-patches, choose a compatible version below and download the bundle. Copy its ACSD-58108/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Bundle prerequisites the same way and list them first. Paths are relative to each package root, using the default -p1 level. Prefer local files when configuring composer-patches; a remote URL can change.

Patch files and compatible versions

Packages across compatible versions (1): magento/module-sales
Packages across compatible versions (1): magento/module-sales

magento/magento2-base >=2.4.7 <2.4.8

Magento Open Source
2.4.7-p10, 2.4.7-p9, 2.4.7-p8, 2.4.7-p7, 2.4.7-p6, 2.4.7-p5, 2.4.7-p4, 2.4.7-p3, 2.4.7-p2, 2.4.7-p1, 2.4.7
Adobe Commerce
2.4.7-p10, 2.4.7-p9, 2.4.7-p8, 2.4.7-p7, 2.4.7-p6, 2.4.7-p5, 2.4.7-p4, 2.4.7-p3, 2.4.7-p2, 2.4.7-p1, 2.4.7
Replaced with
ACP2E-4239
Patch file
patches/os/ACSD-58108_2.4.6.patch
  • vendor/magento/module-sales/Plugin/Model/ResourceModel/Order/OrderGridCollectionFilter.php
  • vendor/magento/module-sales/etc/adminhtml/di.xml

magento/magento2-base >=2.4.6 <2.4.7

Magento Open Source
2.4.6-p15, 2.4.6-p14, 2.4.6-p13, 2.4.6-p12, 2.4.6-p11, 2.4.6-p10, 2.4.6-p9, 2.4.6-p8, 2.4.6-p7, 2.4.6-p6, 2.4.6-p5, 2.4.6-p4, 2.4.6-p3, 2.4.6-p2, 2.4.6-p1, 2.4.6
Adobe Commerce
2.4.6-p15, 2.4.6-p14, 2.4.6-p13, 2.4.6-p12, 2.4.6-p11, 2.4.6-p10, 2.4.6-p9, 2.4.6-p8, 2.4.6-p7, 2.4.6-p6, 2.4.6-p5, 2.4.6-p4, 2.4.6-p3, 2.4.6-p2, 2.4.6-p1, 2.4.6
Patch file
patches/os/ACSD-58108_2.4.6.patch
  • vendor/magento/module-sales/Plugin/Model/ResourceModel/Order/OrderGridCollectionFilter.php
  • vendor/magento/module-sales/etc/adminhtml/di.xml

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.