QUALITY PATCH

ACSD-50478: JS issue for the rollback action in the Backups grid and the database rollback command…

JS issue for the rollback action in the Backups grid and the database rollback command for a case when the DB dump contains triggers and a delimiter SQL command. Quality patch ACSD-50478 for magento/framework applies to Magento Open Source and Adobe Commerce 2.4.0 to 2.4.4-p18.

Categories
Admin, Other
Components
magento/framework, magento/module-backend, magento/module-backup
Origin
adobe-commerce-support
Since QPT
1.1.33

Issue

JS issue for the rollback action in the Backups grid and the database rollback command for a case when the DB dump contains triggers and a delimiter SQL command.

Steps to reproduce

1. Set indexers to Update on Schedule mode so that triggers are created in the database. 1. Enable the backup functionality from the command line: bin/magento config:set system/backup/functionality_enabled 1 1. Go to System > Tools > Backups and generate a DB backup. 1. Open the browser console; you will see the following error: Uncaught SyntaxError: Unexpected token '&' (at (index):606:32) function eventListener8jtGaqtgG2 () { return backup.rollback(&#039;db&#039;, &#039;1678391644&#039;); 1. Try to import the DB from the command line: bin/magento setup:rollback --db-file="<filename>" 1. The following error appears: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'delimiter' at line 1, query was: delimiter ;;

Adobe's page lists 2.4.0 - 2.4.4-p4 as compatible; the versions below are resolved from the current QPT constraints and are the ones the tool will offer.

Adobe scheduled the permanent fix for 2.4.7.

Install

Install the Quality Patches Tool with composer require magento/quality-patches, apply the prerequisites listed for all files applicable to your distribution and version first, then run vendor/bin/magento-patches apply ACSD-50478. On Cloud, add ACSD-50478 under stage.build.QUALITY_PATCHES in .magento.env.yaml.

For cweagans/composer-patches, choose a compatible version below and download the bundle. Copy its ACSD-50478/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Bundle prerequisites the same way and list them first. Paths are relative to each package root, using the default -p1 level. Prefer local files when configuring composer-patches; a remote URL can change.

Patch files and compatible versions

Packages across compatible versions (3): magento/module-backend, magento/module-backup, magento/framework
Packages across compatible versions (3): magento/module-backend, magento/module-backup, magento/framework

magento/magento2-base >=2.4.0 <2.4.5

Magento Open Source
2.4.4-p18, 2.4.4-p17, 2.4.4-p16, 2.4.4-p15, 2.4.4-p14, 2.4.4-p13, 2.4.4-p12, 2.4.4-p11, 2.4.4-p10, 2.4.4-p9, 2.4.4-p8, 2.4.4-p7, 2.4.4-p6, 2.4.4-p5, 2.4.4-p4, 2.4.4-p3, 2.4.4-p2, 2.4.4-p1, 2.4.4, 2.4.3-p3, 2.4.3-p2, 2.4.3-p1, 2.4.3, 2.4.2-p2, 2.4.2-p1, 2.4.2, 2.4.1-p1, 2.4.1, 2.4.0-p1, 2.4.0
Adobe Commerce
2.4.4-p18, 2.4.4-p17, 2.4.4-p16, 2.4.4-p15, 2.4.4-p14, 2.4.4-p13, 2.4.4-p12, 2.4.4-p11, 2.4.4-p10, 2.4.4-p9, 2.4.4-p8, 2.4.4-p7, 2.4.4-p6, 2.4.4-p5, 2.4.4-p4, 2.4.4-p3, 2.4.4-p2, 2.4.4-p1, 2.4.4, 2.4.3-p3, 2.4.3-p2, 2.4.3-p1, 2.4.3, 2.4.2-p2, 2.4.2-p1, 2.4.2, 2.4.1-p1, 2.4.1, 2.4.0-p1, 2.4.0
Patch file
patches/os/ACSD-50478_2.4.3-p1.patch
  • vendor/magento/module-backend/Block/Widget/Grid/Column/Renderer/Action.php
  • vendor/magento/module-backup/Model/ResourceModel/Db.php
  • vendor/magento/framework/Backup/Filesystem/Iterator/File.php

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.