ACSD-61553: Cart Price Rule is incorrectly calculated when multiple discounts with different…
Cart Price Rule is incorrectly calculated when multiple discounts with different priorities are applied. Quality patch ACSD-61553 for magento/module-sales-rule applies to Magento Open Source and Adobe Commerce 2.4.5 to 2.4.7-p10.
- Categories
- Shopping Cart
- Components
- magento/module-sales-rule
- Origin
- adobe-commerce-support
- Since QPT
- 1.1.53
Issue
Cart Price Rule is incorrectly calculated when multiple discounts with different priorities are applied.
Steps to reproduce
1. Create a simple product with a price of $9,000. 1. Create a Cart Price Rule: Rule A with a fixed discount of $700 without any conditions and without discarding subsequent rules. 1. Create another Cart Price Rule: Rule B with a fixed discount of $1000 without any conditions and without discarding subsequent rules. 1. Add the product with the quantity 13 to the cart. 1. Update the rules with any of the below scenarios: Scenario 01 Rule A Priority: 1 Maximum Qty Discount is Applied To: 1 Rule B Priority: 0 Maximum Qty Discount is Applied To: 0 Scenario 02 Rule A Priority: 0 Maximum Qty Discount is Applied To: 0 Rule B Priority: 1 Maximum Qty Discount is Applied To: 1 Scenario 03 Rule A Priority: 0 Maximum Qty Discount is Applied To: 0 Rule B Priority: 0 Maximum Qty Discount is Applied To: 1 1. Click the Update Shopping Cart button to recalculate the discounts.
Adobe's page lists 2.4.5 - 2.4.6-p8 as compatible; the versions below are resolved from the current QPT constraints and are the ones the tool will offer.
Adobe scheduled the permanent fix for 2.4.8.
Install
Install the Quality Patches Tool with composer require magento/quality-patches, apply the prerequisites listed for all files applicable to your distribution and version first, then run vendor/bin/magento-patches apply ACSD-61553. On Cloud, add ACSD-61553 under stage.build.QUALITY_PATCHES in .magento.env.yaml.
For cweagans/composer-patches, choose a compatible version below and download the bundle. Copy its ACSD-61553/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Bundle prerequisites the same way and list them first. Paths are relative to each package root, using the default -p1 level. Prefer local files when configuring composer-patches; a remote URL can change.
Patch files and compatible versions
magento/magento2-base >=2.4.5 <2.4.7
- Magento Open Source
- 2.4.6-p15, 2.4.6-p14, 2.4.6-p13, 2.4.6-p12, 2.4.6-p11, 2.4.6-p10, 2.4.6-p9, 2.4.6-p8, 2.4.6-p7, 2.4.6-p6, 2.4.6-p5, 2.4.6-p4, 2.4.6-p3, 2.4.6-p2, 2.4.6-p1, 2.4.6, 2.4.5-p17, 2.4.5-p16, 2.4.5-p15, 2.4.5-p14, 2.4.5-p13, 2.4.5-p12, 2.4.5-p11, 2.4.5-p10, 2.4.5-p9, 2.4.5-p8, 2.4.5-p7, 2.4.5-p6, 2.4.5-p5, 2.4.5-p4, 2.4.5-p3, 2.4.5-p2, 2.4.5-p1, 2.4.5
- Adobe Commerce
- 2.4.6-p15, 2.4.6-p14, 2.4.6-p13, 2.4.6-p12, 2.4.6-p11, 2.4.6-p10, 2.4.6-p9, 2.4.6-p8, 2.4.6-p7, 2.4.6-p6, 2.4.6-p5, 2.4.6-p4, 2.4.6-p3, 2.4.6-p2, 2.4.6-p1, 2.4.6, 2.4.5-p17, 2.4.5-p16, 2.4.5-p15, 2.4.5-p14, 2.4.5-p13, 2.4.5-p12, 2.4.5-p11, 2.4.5-p10, 2.4.5-p9, 2.4.5-p8, 2.4.5-p7, 2.4.5-p6, 2.4.5-p5, 2.4.5-p4, 2.4.5-p3, 2.4.5-p2, 2.4.5-p1, 2.4.5
- Patch file
- patches/os/ACSD-61553_2.4.5-p8.patch
- vendor/magento/module-sales-rule/Model/Rule/Action/Discount/ByFixed.php
- vendor/magento/module-sales-rule/Model/Utility.php
magento/magento2-base >=2.4.7 <2.4.8
- Magento Open Source
- 2.4.7-p10, 2.4.7-p9, 2.4.7-p8, 2.4.7-p7, 2.4.7-p6, 2.4.7-p5, 2.4.7-p4, 2.4.7-p3, 2.4.7-p2, 2.4.7-p1, 2.4.7
- Adobe Commerce
- 2.4.7-p10, 2.4.7-p9, 2.4.7-p8, 2.4.7-p7, 2.4.7-p6, 2.4.7-p5, 2.4.7-p4, 2.4.7-p3, 2.4.7-p2, 2.4.7-p1, 2.4.7
- Replaced with
- ACSD-63469
- Patch file
- patches/os/ACSD-62648_2.4.7-p2.patch
- vendor/magento/module-sales-rule/Model/Rule/Action/Discount/ByFixed.php
- vendor/magento/module-sales-rule/Model/Utility.php
