ACSD-65938: Gift card emails were sent before confirming that the invoice was successfully created…
Gift card emails were sent before confirming that the invoice was successfully created and saved, resulting in emails being sent even when invoice creation failed. Quality patch ACSD-65938 for magento/module-gift-card applies to Magento Open Source and Adobe Commerce 2.4.4 to 2.4.8-p5.
- Categories
- Catalog/Product, Order/Checkout, Emails
- Components
- magento/module-gift-card
- Origin
- adobe-commerce-support
- Since QPT
- 1.1.68
Issue
Gift card emails were sent before confirming that the invoice was successfully created and saved, resulting in emails being sent even when invoice creation failed.
Steps to reproduce
1. Log in to the Admin panel. 2. Navigate to Stores > Settings > Configuration > Sales > Gift Cards > Gift Card General Settings, and set Generate Gift Card Account when Order Item is to Invoiced. 3. Create a new gift card product. 4. Add gift cart product to cart and proceed to checkout. You can use Check/Money Order as the payment method. 5. Place the order. 6. Modify the OrderRepository to simulate an exception during order placement. 7. Send a POST request to rest/default/V1/order/<ORDER_ID>/invoice with the following payload: { "capture": true, "notify": true }
Adobe's page lists 2.4.4 - 2.4.8-p1 as compatible; the versions below are resolved from the current QPT constraints and are the ones the tool will offer.
Adobe scheduled the permanent fix for 2.4.9.
Install
Install the Quality Patches Tool with composer require magento/quality-patches, apply the prerequisites listed for all files applicable to your distribution and version first, then run vendor/bin/magento-patches apply ACSD-65938. On Cloud, add ACSD-65938 under stage.build.QUALITY_PATCHES in .magento.env.yaml.
For cweagans/composer-patches, choose a compatible version below and download the bundle. Copy its ACSD-65938/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Bundle prerequisites the same way and list them first. Paths are relative to each package root, using the default -p1 level. Prefer local files when configuring composer-patches; a remote URL can change.
Patch files and compatible versions
magento/magento2-ee-base >=2.4.4 <2.4.9
- Magento Open Source
- —
- Adobe Commerce
- 2.4.8-p5, 2.4.8-p4, 2.4.8-p3, 2.4.8-p2, 2.4.8-p1, 2.4.8, 2.4.7-p10, 2.4.7-p9, 2.4.7-p8, 2.4.7-p7, 2.4.7-p6, 2.4.7-p5, 2.4.7-p4, 2.4.7-p3, 2.4.7-p2, 2.4.7-p1, 2.4.7, 2.4.6-p15, 2.4.6-p14, 2.4.6-p13, 2.4.6-p12, 2.4.6-p11, 2.4.6-p10, 2.4.6-p9, 2.4.6-p8, 2.4.6-p7, 2.4.6-p6, 2.4.6-p5, 2.4.6-p4, 2.4.6-p3, 2.4.6-p2, 2.4.6-p1, 2.4.6, 2.4.5-p17, 2.4.5-p16, 2.4.5-p15, 2.4.5-p14, 2.4.5-p13, 2.4.5-p12, 2.4.5-p11, 2.4.5-p10, 2.4.5-p9, 2.4.5-p8, 2.4.5-p7, 2.4.5-p6, 2.4.5-p5, 2.4.5-p4, 2.4.5-p3, 2.4.5-p2, 2.4.5-p1, 2.4.5, 2.4.4-p18, 2.4.4-p17, 2.4.4-p16, 2.4.4-p15, 2.4.4-p14, 2.4.4-p13, 2.4.4-p12, 2.4.4-p11, 2.4.4-p10, 2.4.4-p9, 2.4.4-p8, 2.4.4-p7, 2.4.4-p6, 2.4.4-p5, 2.4.4-p4, 2.4.4-p3, 2.4.4-p2, 2.4.4-p1, 2.4.4
- vendor/magento/module-gift-card/Model/GenerateGiftCardAccounts.php (added)
- vendor/magento/module-gift-card/Observer/AdminGenerateGiftCardAccounts.php (added)
- vendor/magento/module-gift-card/Observer/GenerateGiftCardAccountsInvoice.php (deleted)
- vendor/magento/module-gift-card/Plugin/Sales/Model/GenerateGiftCardAccountsInvoice.php (added)
- vendor/magento/module-gift-card/etc/adminhtml/events.xml
- vendor/magento/module-gift-card/etc/di.xml
- vendor/magento/module-gift-card/etc/events.xml
