QUALITY PATCH

ACSD-68190: The discounts don't apply, applied discounts don't display correctly in the GraphQL cart…

The discounts don't apply, applied discounts don't display correctly in the GraphQL cart view response, and non-coupon discounts are removed on removing a coupon discount. Quality patch ACSD-68190 for magento/module-sales-rule applies to Magento Open Source and Adobe Commerce 2.4.4 to 2.4.6-p15.

Categories
Shopping Cart, Price/Tax, GraphQL
Components
magento/module-sales-rule, magento/module-advanced-rule, magento/module-advanced-sales-rule
Origin
adobe-commerce-support
Since QPT
1.1.73

Issue

The discounts don't apply, applied discounts don't display correctly in the GraphQL cart view response, and non-coupon discounts are removed on removing a coupon discount.

Steps to reproduce

1. Create the following category tree: 1. New Root Category 1. category1 1. subcategory 1.1 1. Go to Stores > Stores and assign the newly created root category to your store. 1. Create a new product and assign it to category1. 1. Create Rule1 applicable to category1 (no coupon required). 1. Set "Discard subsequent rules" = NO. 1. Create Rule2 (specific coupon required). 1. Set "Discard subsequent rules" = NO 1. Create a customer. 1. Use GraphQL to get customer token. 1. Add product to cart using GraphQL. 1. Check that Rule1 (non-coupon discount) is not applied initially. 1. Apply coupon using GraphQL applyCouponToCart mutation. 1. Verify both Rule1 and Rule2 discounts are now applied. 1. Remove coupon using GraphQL removeCouponFromCart mutation.

Adobe's page lists 2.4.4 - 2.4.6-p13 as compatible; the versions below are resolved from the current QPT constraints and are the ones the tool will offer.

Adobe scheduled the permanent fix for 2.4.8.

Install

Install the Quality Patches Tool with composer require magento/quality-patches, apply the prerequisites listed for all files applicable to your distribution and version first, then run vendor/bin/magento-patches apply ACSD-68190. On Cloud, add ACSD-68190 under stage.build.QUALITY_PATCHES in .magento.env.yaml.

For cweagans/composer-patches, choose a compatible version below and download the bundle. Copy its ACSD-68190/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Bundle prerequisites the same way and list them first. Paths are relative to each package root, using the default -p1 level. Prefer local files when configuring composer-patches; a remote URL can change.

Patch files and compatible versions

Packages across compatible versions (1): magento/module-sales-rule
Packages across compatible versions (3): magento/module-sales-rule, magento/module-advanced-rule, magento/module-advanced-sales-rule

magento/magento2-ee-base >=2.4.4 <2.4.7

Magento Open Source
—
Adobe Commerce
2.4.6-p15, 2.4.6-p14, 2.4.6-p13, 2.4.6-p12, 2.4.6-p11, 2.4.6-p10, 2.4.6-p9, 2.4.6-p8, 2.4.6-p7, 2.4.6-p6, 2.4.6-p5, 2.4.6-p4, 2.4.6-p3, 2.4.6-p2, 2.4.6-p1, 2.4.6, 2.4.5-p17, 2.4.5-p16, 2.4.5-p15, 2.4.5-p14, 2.4.5-p13, 2.4.5-p12, 2.4.5-p11, 2.4.5-p10, 2.4.5-p9, 2.4.5-p8, 2.4.5-p7, 2.4.5-p6, 2.4.5-p5, 2.4.5-p4, 2.4.5-p3, 2.4.5-p2, 2.4.5-p1, 2.4.5, 2.4.4-p18, 2.4.4-p17, 2.4.4-p16, 2.4.4-p15, 2.4.4-p14, 2.4.4-p13, 2.4.4-p12, 2.4.4-p11, 2.4.4-p10, 2.4.4-p9, 2.4.4-p8, 2.4.4-p7, 2.4.4-p6, 2.4.4-p5, 2.4.4-p4, 2.4.4-p3, 2.4.4-p2, 2.4.4-p1, 2.4.4
Patch file
patches/commerce/ACSD-68190_2.4.6-p3.patch
  • vendor/magento/module-advanced-rule/Model/Condition/Filter.php
  • vendor/magento/module-advanced-rule/Model/Condition/FilterInterface.php
  • vendor/magento/module-advanced-sales-rule/Model/Indexer/SalesRule/AbstractAction.php
  • vendor/magento/module-advanced-sales-rule/Model/ResourceModel/Rule/Condition/Filter.php
  • vendor/magento/module-advanced-sales-rule/Model/Rule/Condition/FilterTextGenerator/Product/Category.php
  • vendor/magento/module-advanced-sales-rule/etc/db_schema.xml

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.