QUALITY PATCH

ACSD-48448: Race condition issue is happening during order cancellations…

Race condition issue is happening during order cancellations, which causes duplicated entries in the inventory_reservation table. Quality patch ACSD-48448 for magento/module-sales applies to Magento Open Source and Adobe Commerce 2.4.2 to 2.4.6-p15.

Categories
Order/Checkout, Inventory
Components
magento/module-sales
Origin
adobe-commerce-support
Since QPT
1.1.34

Issue

Race condition issue is happening during order cancellations, which causes duplicated entries in the inventory_reservation table.

Steps to reproduce

1. Place an order. 1. Check the inventory_reservation table to make sure there is a record for the order_placed event. 1. Run the attached script to cancel the order in parallel (remember to change the URL and orderID). bash cancel_order.sh #!/bin/bash baseUrl=" " orderId=3 token=$(curl --location --request POST "${baseUrl}rest/V1/integration/admin/token" \ -H 'Content-Type: application/json' \ -d '{ "username": "admin", "password": "password" }') echo ${token//\"/} curl --location --request POST "${baseUrl}/rest/V1/orders/${orderId}/cancel" \ -H "Authorization:Bearer ${token//\"/}" \ -H 'Content-Type: application/json' \ & sleep 0.1; curl --location --request POST "${baseUrl}/rest/V1/orders/${orderId}/cancel" \ -H "Authorization:Bearer ${token//\"/}" \ -H 'Content-Type: application/json' \ wait

Adobe's page lists 2.4.2 - 2.4.6-p2 as compatible; the versions below are resolved from the current QPT constraints and are the ones the tool will offer.

Adobe scheduled the permanent fix for 2.4.7.

Install

Install the Quality Patches Tool with composer require magento/quality-patches, apply the prerequisites listed for all files applicable to your distribution and version first, then run vendor/bin/magento-patches apply ACSD-48448. On Cloud, add ACSD-48448 under stage.build.QUALITY_PATCHES in .magento.env.yaml.

For cweagans/composer-patches, choose a compatible version below and download the bundle. Copy its ACSD-48448/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Bundle prerequisites the same way and list them first. Paths are relative to each package root, using the default -p1 level. Prefer local files when configuring composer-patches; a remote URL can change.

Patch files and compatible versions

Packages across compatible versions (1): magento/module-sales
Packages across compatible versions (1): magento/module-sales

magento/magento2-base >=2.4.2 <2.4.4

Magento Open Source
2.4.3-p3, 2.4.3-p2, 2.4.3-p1, 2.4.3, 2.4.2-p2, 2.4.2-p1, 2.4.2
Adobe Commerce
2.4.3-p3, 2.4.3-p2, 2.4.3-p1, 2.4.3, 2.4.2-p2, 2.4.2-p1, 2.4.2
Requires
MDVA-40399
Patch file
patches/os/ACSD-48448_2.4.2-p2.patch
  • vendor/magento/module-sales/Model/Service/OrderService.php

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.