ACSD-66120: GraphQL incorrectly displays discount percentages and base prices…

Categories

GraphQL, Price/Tax

Components

magento/module-catalog-graph-ql, magento/module-catalog-rule, magento/module-tax

Origin

adobe-commerce-support

Since QPT

1.1.70

Issue

GraphQL incorrectly displays discount percentages and base prices when catalog prices are configured to include tax. Due to rounding errors, the discount percentage shows as 19.99% instead of the configured 20%.

Steps to reproduce

1. Go to Stores > Settings > Configuration > Catalog > Catalog > Price. 1. Set Catalog Price Scope to Website. 1. Go to Stores > Settings > Configuration > Sales > Tax > Calculation Settings. 1. Set Tax Calculation Method Based On to Unit Price. 1. Set Catalog Prices to Including Tax. 1. Set Apply Discount On Prices to Including Tax. 1. Go to Stores > Settings > Configuration > Sales > Tax > Default Tax Destination Calculation. 1. Set Default Country to France. 1. Go to Stores > Tax Zones and Rates > Add new Tax Rate. 1. Enter any name in the Tax Identifier field. 1. Enter an asterisk (*) in the Zip/Post Code field. 1. Set Country to France. 1. Enter 20.000000 in the Rate Percent field. 1. Click Save. 1. Go to Stores > Tax Rules > Add New Tax Rule. 1. Enter any name in the Name field. 1. Set Tax Rate to rate added in previous step. 1. Go to Catalog > Products > Add Product. 1. Enter test in the Product Name field. 1. Enter test in the SKU field. 1. Enter 82.65 in the Price field. 1. Set Tax Class to Taxable Goods. 1. Enter 100 in the Quantity field. 1. Click Save. 1. Change scope to Default Store View. 1. Unset Use Default Value on Price. 1. Set Price to 68.87. 1. Unset Use Default Value on Tax Class. 1. Set Tax Class to Taxable goods. 1. Click Save. 1. Go to Marketing > Promotions > Catalog Price Rule > Add New Rule. 1. Enter any name in the Rule Name field. 1. Set Active to Yes. 1. Set Website to Main Website. 1. Set Customer Groups to all 1. Under Actions, set Apply to Apply as percentage of original. 1. Enter 20.000000 in the Discount Amount field. 1. Click Save. 1. Perform a full reindex: $ bin/magento index:reindex 1. Perform the following GraphQL query with Store: default set in the headers: query{ products(filter: {sku: {eq: "test"}}, sort: {name: ASC}) { items { name sku price_range { minimum_price { regular_price { value currency } final_price { value currency } discount { amount_off percent_off } } maximum_price { regular_price { value currency } final_price { value currency } discount { amount_off percent_off } } } } } }

Adobe's page lists 2.4.4 - 2.4.8-p2 as compatible; the versions below are resolved from the current QPT constraints and are the ones the tool will offer.

Adobe scheduled the permanent fix for 2.4.9.

Install

Install the Quality Patches Tool with composer require magento/quality-patches, apply the prerequisites listed for all files applicable to your distribution and version first, then run vendor/bin/magento-patches apply ACSD-66120. On Cloud, add ACSD-66120 under stage.build.QUALITY_PATCHES in .magento.env.yaml.

For cweagans/composer-patches, choose a compatible version below and download the bundle. Copy its ACSD-66120/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Bundle prerequisites the same way and list them first. Paths are relative to each package root, using the default -p1 level. Prefer local files when configuring composer-patches; a remote URL can change.

Patch files and compatible versions

Sources

• Adobe documentation for ACSD-66120
• JSON API: /api/v1/patches/ACSD-66120